Skip to content

Conversation

@djtazty1984
Copy link

@djtazty1984 djtazty1984 commented Dec 16, 2025

  • The entra id support for installer download reuses existing entra id code for rest source access (parsing, authenticating).
  • Added yaml manifest parsing for authentication to make manifest in parity with rest source. Added validation to disable Authentication in manifest for community repo.
  • Validated manually with private Azure blob storage hosted installer.
  • Added manifest tests and installer download authentication unit tests


Microsoft Reviewers: Open in CodeFlow

- The entra id support for installer download reuses existing entra id
code for rest source access (parsing, authenticating).
- Added yaml manifest parsing for authentication to make manifest in
parity with rest source. Added validation to disable Authentication in
manifest for community repo.
- Validated manually with private Azure blob storage hosted installer.
- Added manifest tests and installer download authentication unit tests

<!-- To check a checkbox place an "x" between the brackets. e.g: [x] -->

- [ ] I have signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs).
- [ ] This pull request is related to an issue.

-----
@djtazty1984 djtazty1984 requested a review from a team as a code owner December 16, 2025 14:06
@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (2)

edgedevtools
startpage

These words are not needed and should be removed AAD ABCD abi acl AMap Amd appdata ARMNT asan Baz bitmask bluetooth brk Buf certs cgi CMSG codepage commandline constexpr Cov cswinrt CTL Dbg decompressor dedupe DEFT devhome Dns dsc ERANGE errcode errmsg errstr filemode Finalizers FULLWIDTH fuzzer GES github HINSTANCE hlocal hmac Hyperlink ICONDIR icu idx img inet Intelli iwr JDK LCID lhs LONGLONG LPBYTE LPCWSTR LPDWORD LPSTR LPVOID LPWSTR MAJORVERSION MAXLENGTH MDs MINORVERSION mta nlohmann NONAME NOUPDATE NTFS ofile oid oop OPTOUT outfile OUTOFMEMORY pdb PDWORD pid PKCS pkix placeholders positionals posix pseudocode PSHOST publickey qword redirector regexes remoting reparse REQS rhs rowid RTTI runspace runtimes SARL savepoint sid sqlite subdir subkey ttl typedef uninitialize uninstallation UNMARSHALING userprofile versioned Webserver website wildcards winreg workaround wsl

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:djtazty1984/winget-cli.git repository
on the master branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/winget-cli/actions/runs/20270702685/attempts/1'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@ItzLevvie
Copy link

Close with reason: Invalid pull request - description was copied from PR 5095;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants