Skip to content

Improve Installer Type Detection for YamlCreate #270943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 8, 2025

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Jul 3, 2025

Checklist for Pull Requests

This PR improves the installer type detection in YamlCreate by relying on the actual binary of the file instead of just the file extension.

cc @mdanish-kh @denelon

Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from denelon as a code owner July 3, 2025 13:26
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jul 3, 2025
@denelon
Copy link
Collaborator

denelon commented Jul 3, 2025

Does this require any changes to component governance, or are these just "new"/"recent" versions of libraries being pulled in?

@Trenly
Copy link
Contributor Author

Trenly commented Jul 3, 2025

Does this require any changes to component governance, or are these just "new"/"recent" versions of libraries being pulled in?

@denelon - powershell-yaml is just a new version; The other two - MSI and NTObjectManager are new and will likely require component governance review.

@Trenly
Copy link
Contributor Author

Trenly commented Jul 3, 2025

Co-authored-by: Muhammad Danish <[email protected]>
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jul 7, 2025
@Trenly Trenly requested a review from mdanish-kh July 7, 2025 21:12
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 8, 2025
Copy link
Contributor

@mdanish-kh mdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Test-Inno not working would be the only blocking comment

  2. nit: For consistency since you used the hexadecimal notation in Test-IsFont, we may either want to modify all decimal notations where we use byte[] to follow hexa, or change the hexa to be decimal notation in Test-IsFont. I'm partial towards the hexadecimal style as it's easier to read and matches with the tools one may use to inspect these files

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jul 8, 2025
Co-authored-by: Muhammad Danish <[email protected]>
@microsoft-github-policy-service microsoft-github-policy-service bot removed Changes-Requested Changes Requested Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Author-Feedback This needs a response from the author. labels Jul 8, 2025
@Trenly Trenly requested a review from mdanish-kh July 8, 2025 14:41
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 8, 2025
@denelon denelon merged commit 71a50f5 into microsoft:master Jul 8, 2025
2 checks passed
@Trenly Trenly deleted the InstallerDetection branch July 8, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Project-File
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants