-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Improve Installer Type Detection for YamlCreate #270943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does this require any changes to component governance, or are these just "new"/"recent" versions of libraries being pulled in? |
@denelon - |
Licenses
|
Co-authored-by: Muhammad Danish <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Test-Inno not working would be the only blocking comment
-
nit: For consistency since you used the hexadecimal notation in
Test-IsFont
, we may either want to modify all decimal notations where we usebyte[]
to follow hexa, or change the hexa to be decimal notation inTest-IsFont
. I'm partial towards the hexadecimal style as it's easier to read and matches with the tools one may use to inspect these files
Co-authored-by: Muhammad Danish <[email protected]>
Checklist for Pull Requests
This PR improves the installer type detection in YamlCreate by relying on the actual binary of the file instead of just the file extension.
cc @mdanish-kh @denelon
Microsoft Reviewers: Open in CodeFlow