Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -94,7 +94,7 @@ func GetServerAddress(cc *grpc.ClientConn) string { | |||
| defer mux.Unlock() | |||
There was a problem hiding this comment.
probably can just remove this file to keep the commit history simple
| @@ -39,19 +39,21 @@ require ( | |||
| github.com/spf13/pflag v1.0.5 // indirect | |||
There was a problem hiding this comment.
same as other prs, make sure to remove all changes from these files before merge
| return nil, err | ||
| } | ||
|
|
||
| mocResponse, err := c.VirtualMachineAgentClient.GetHyperVVmId(ctx, vm[0]) |
There was a problem hiding this comment.
Just to be safe, can we make sure the vm list is non-empty before accessing it?
| return nil, err | ||
| } | ||
|
|
||
| mocResponse, err := c.VirtualMachineAgentClient.GetHyperVVmId(ctx, vm[0]) |
There was a problem hiding this comment.
Is there a specific reason we aren’t using the INVOKE function for the calls to cloudAgent? It already has RBAC, redaction, and common logging built in.
Would it make sense to embed these new function calls within INVOKE to take advantage of those built-in features?
There was a problem hiding this comment.
These functions are not running operations on the VM, they are simply getting and passing up information from set fields.
4 participants
No description provided.