Skip to content

feat: update moc dependency for enriched VM Get fields#363

Closed
jocardeMSFT wants to merge 1 commit intomasterfrom
users/jocarde/vm-get-all
Closed

feat: update moc dependency for enriched VM Get fields#363
jocardeMSFT wants to merge 1 commit intomasterfrom
users/jocarde/vm-get-all

Conversation

@jocardeMSFT
Copy link
Contributor

Summary

Problem Statement

The wssd-sdk-for-go needs to pick up the updated moc proto that includes the new hyperVVmId and hostNodeIpAddress fields on the VirtualMachine message.

Proposed Solution

  • Update go.mod to reference the moc dependency from the vm-get-all branch

Dependencies

Testing Complete

  • go build ./... succeeds
  • Manual testing pending

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github.com/golang/protobuf v1.5.4
github.com/google/go-cmp v0.7.0
github.com/microsoft/moc v0.39.0
github.com/microsoft/moc v0.39.2-0.20260219214136-f96a5875ae97

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - would be nice to just rev the patch version, but I'm fine with this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the pre rollup, this is my commit reference from my branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged. Will update to the released version once the upstream moc PR merges and gets tagged.


This reply was written by AI

@jocardeMSFT
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jocardeMSFT
Copy link
Contributor Author

All gates passed with SDK

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants