Skip to content

Network - 26887 - Diagnostic logging is enabled in Azure Firewall#922

Merged
SagarSathe merged 3 commits intomainfrom
test-26887-fresh
Feb 20, 2026
Merged

Network - 26887 - Diagnostic logging is enabled in Azure Firewall#922
SagarSathe merged 3 commits intomainfrom
test-26887-fresh

Conversation

@aahmed-spec
Copy link
Collaborator

Diagnostic logging is enabled in Azure Firewall
spec

Old PR #907

@aahmed-spec aahmed-spec self-assigned this Feb 19, 2026
@aahmed-spec aahmed-spec added the ready for review PR is ready for review and merging label Feb 19, 2026
@aahmed-spec
Copy link
Collaborator Author

Hi @alexandair

I have made the changes as suggested in #907 (review)

@aahmed-spec aahmed-spec marked this pull request as ready for review February 19, 2026 11:45
@alexandair alexandair requested a review from Copilot February 19, 2026 12:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Zero Trust assessment test (ID 26887) to evaluate whether Azure Firewall resources have diagnostic logging enabled with an appropriate destination, plus the accompanying markdown guidance content.

Changes:

  • Introduces Test-Assessment-26887 PowerShell test to discover Azure Firewalls via Azure Resource Graph and evaluate their diagnostic settings.
  • Generates markdown report output summarizing diagnostic settings status per firewall.
  • Adds remediation/description markdown content for test 26887.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/powershell/tests/Test-Assessment.26887.ps1 Implements Azure Firewall diagnostic settings discovery, evaluation logic, and report rendering.
src/powershell/tests/Test-Assessment.26887.md Adds narrative risk context and remediation links, with a %TestResult% placeholder for output injection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@alexandair alexandair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarSathe SagarSathe merged commit 899e1d5 into main Feb 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review PR is ready for review and merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants