Skip to content

fix: fluent v9 upgrade accessibility issues from Accessibility Insights#3593

Merged
Mnickii merged 12 commits intofeat/fluent-v9-upgradefrom
fix/v9-accessibility-fixes
Feb 24, 2025
Merged

fix: fluent v9 upgrade accessibility issues from Accessibility Insights#3593
Mnickii merged 12 commits intofeat/fluent-v9-upgradefrom
fix/v9-accessibility-fixes

Conversation

@ElinorW
Copy link
Contributor

@ElinorW ElinorW commented Feb 11, 2025 •
edited
Loading

Overview

Fixes #3592

Demo

Notes

Known issue regarding the aria-hidden-focus brought about by the tabs
image

the fluent team has shared this in regard to that issue on their Wiki
image

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3593.eastus2.4.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3593.eastus2.4.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3593.eastus2.4.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3593.eastus2.4.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3593.eastus2.4.azurestaticapps.net

@ElinorW ElinorW marked this pull request as ready for review February 21, 2025 13:09
@ElinorW ElinorW requested a review from a team as a code owner February 21, 2025 13:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3593.eastus2.4.azurestaticapps.net

@ElinorW ElinorW marked this pull request as draft February 24, 2025 08:14
@ElinorW ElinorW changed the title fix: fluent v9 upgrade accessibility issues fix: fluent v9 upgrade accessibility issues from Accessibility Insights Feb 24, 2025
@ElinorW ElinorW marked this pull request as ready for review February 24, 2025 14:17
@Mnickii Mnickii merged commit 7a9b2bd into feat/fluent-v9-upgrade Feb 24, 2025
15 of 16 checks passed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Mnickii Mnickii mentioned this pull request Feb 26, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@musale musale musale approved these changes

@Mnickii Mnickii Mnickii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ElinorW @musale @Mnickii