Skip to content

fix: correct CTA buttons#3650

Merged
Mnickii merged 4 commits intofeat/fluent-v9-upgradefrom
fix/collection-buttons
Feb 25, 2025
Merged

fix: correct CTA buttons#3650
Mnickii merged 4 commits intofeat/fluent-v9-upgradefrom
fix/collection-buttons

Conversation

@Mnickii
Copy link
Contributor

@Mnickii Mnickii commented Feb 25, 2025

Overview

Closes #3649

Brief description of what this PR does, and why it is needed.

Demo

Screenshot_25-2-2025_12213_localhost
Screenshot_25-2-2025_122027_localhost

@Mnickii Mnickii requested a review from a team as a code owner February 25, 2025 09:21
@Mnickii Mnickii changed the title fix CTA buttons fix: correct CTA buttons Feb 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3650.eastus2.4.azurestaticapps.net

musale
musale reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give it a background color instead of it being transparent?
image
Is there a reason to have it transparent? With this update it'll look much cleaner with a background color.

background-on-cta.mp4

@Mnickii
Copy link
Contributor Author

Mnickii commented Feb 25, 2025

Yeah it needs a bg color, updating

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3650.eastus2.4.azurestaticapps.net

@Mnickii Mnickii requested a review from musale February 25, 2025 09:59
@Mnickii Mnickii requested a review from ElinorW February 25, 2025 12:29
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3650.eastus2.4.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3650.eastus2.4.azurestaticapps.net

@Mnickii Mnickii merged commit 1022070 into feat/fluent-v9-upgrade Feb 25, 2025
14 of 15 checks passed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Mnickii Mnickii mentioned this pull request Feb 25, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@musale musale Awaiting requested review from musale

1 more reviewer

@ElinorW ElinorW ElinorW approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mnickii @musale @ElinorW