Skip to content

fix: code snippets UI enhancements #3798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ElinorW merged 4 commits into from
Apr 16, 2025
Merged

fix: code snippets UI enhancements #3798

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
392c2ea
fix space on code snippets
ElinorW Apr 15, 2025
3c63a80
sorting tabs in alphabetical order
ElinorW Apr 15, 2025
48b006e
add padding for clear focus line
ElinorW Apr 15, 2025
e74c875
Merge branch 'dev' into fix/code-snippets-enhancements
ElinorW Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/views/common/monaco/Monaco.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ const Monaco = ({ body, onChange, language, readOnly, height, extraInfoElement,
{extraInfoElement}
<Editor
language={language || 'json'}
width=' 100%'
height=' 100%'
width='100%'
height='100%'
value={formattedBody}
options={editorOptions}
onChange={onChange}
Expand Down
2 changes: 1 addition & 1 deletion src/app/views/query-response/pivot-items/pivot-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const useStyles = makeStyles({
backgroundColor: tokens.colorNeutralBackground1,
height: '100%',
minHeight: '600px',
overflow: 'auto'
overflow: 'hidden'
}
});

Expand Down
20 changes: 11 additions & 9 deletions src/app/views/query-response/snippets/Snippets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const useSnippetStyles = makeStyles({
container: {
margin: '0 auto',
maxHeight: '100vh',
overflowY: 'auto',
overflowY: 'hidden',
display: 'flex',
flexDirection: 'column'
},
Expand All @@ -78,16 +78,15 @@ const useSnippetStyles = makeStyles({
display: 'flex',
flexDirection: 'column',
flex: '1 1 auto',
height: '30vh',
overflowY: 'auto'
height: '60vh'
},
copyButton: {
marginLeft: 'auto'
},
snippetContent: {
display: 'flex',
flexDirection: 'column',
overflowY: 'auto',
overflowY: 'hidden',
maxHeight: 'calc(100vh-120px)'
}
});
Expand Down Expand Up @@ -201,11 +200,14 @@ const RenderSnippets = () => {
return (
<div id='snippets-tablist' className={styles.container}>
<TabList selectedValue={selectedLanguage} onTabSelect={onTabSelect}>
{Object.keys(supportedLanguages).map((language: string) => (
<Tab key={language} value={language}>
{language === 'CSharp' ? 'C#' : language}
</Tab>
))}
<Tab key='CSharp' value='CSharp'>C#</Tab>
{/*The rest should be sorted in alphabetical order to match docs */}
{Object.keys(supportedLanguages)
.filter(lang => lang !== 'CSharp')
.sort((a, b) => a.localeCompare(b))
.map(language => (
<Tab key={language} value={language}>{language}</Tab>
))}
</TabList>
<div id='snippet-content'>
<SnippetContent language={selectedLanguage as string} />
Expand Down
Loading