Skip to content

fix: ediscovery mandatory parameter removal #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 1 commit into from
Apr 9, 2025
Merged

fix: ediscovery mandatory parameter removal #809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions transforms/csdl/preprocess_csdl.xsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,8 @@
<!-- This should be a temp fix, tracking: https://github.com/microsoft/OpenAPI.NET.OData/issues/582 -->
<xsl:template match="edm:Schema[@Namespace='microsoft.graph']/edm:Action[@Name='verify']/edm:Parameter[@Name='forceTakeover']"/>

<xsl:template match="edm:Schema[@Namespace='microsoft.graph.security']/edm:Action[@Name='estimateStatistics']/edm:Parameter[@Name='statisticsOptions']"/>

<!-- Remove action parameters -->
<!-- This should be a temp fix, tracking: https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator/issues/261 -->
<!-- <xsl:template match="edm:Schema[@Namespace='microsoft.graph']/edm:Action[@Name='createUploadSession']/edm:Parameter[@Name='deferCommit']"/> -->
Expand Down
18 changes: 18 additions & 0 deletions transforms/csdl/preprocess_csdl_test_input.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,5 +651,23 @@
<Annotation Term="Org.OData.Capabilities.V1.SkipSupported" Bool="false" />
</Annotations>
</Schema>
<Schema Namespace="microsoft.graph.security" xmlns="http://docs.oasis-open.org/odata/ns/edm">
<EnumType Name="statisticsOptions" IsFlags="true">
<Member Name="includeRefiners" Value="1" />
<Member Name="includeQueryStats" Value="2" />
<Member Name="includeUnindexedStats" Value="4" />
<Member Name="advancedIndexing" Value="8" />
<Member Name="locationsWithoutHits" Value="16" />
<Member Name="unknownFutureValue" Value="32" />
</EnumType>
<EntityType Name="ediscoverySearch">
<Property Name="dummyProperty" Type="string" />
<!-- this is partial since we only need the entity type for the action-->
</EntityType>
<Action Name="estimateStatistics" IsBound="true">
<Parameter Name="bindingParameter" Type="microsoft.graph.security.ediscoverySearch" />
<Parameter Name="statisticsOptions" Type="microsoft.graph.security.statisticsOptions" />
</Action>
</Schema>
</edmx:DataServices>
</edmx:Edmx>
17 changes: 17 additions & 0 deletions transforms/csdl/preprocess_csdl_test_output.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1677,5 +1677,22 @@
</Annotation>
</Annotations>
</Schema>
<Schema Namespace="microsoft.graph.security" xmlns="http://docs.oasis-open.org/odata/ns/edm">
<EnumType Name="statisticsOptions" IsFlags="true">
<Member Name="includeRefiners" Value="1" />
<Member Name="includeQueryStats" Value="2" />
<Member Name="includeUnindexedStats" Value="4" />
<Member Name="advancedIndexing" Value="8" />
<Member Name="locationsWithoutHits" Value="16" />
<Member Name="unknownFutureValue" Value="32" />
</EnumType>
<EntityType Name="ediscoverySearch">
<Property Name="dummyProperty" Type="string" />
<!-- this is partial since we only need the entity type for the action-->
</EntityType>
<Action Name="estimateStatistics" IsBound="true">
<Parameter Name="bindingParameter" Type="microsoft.graph.security.ediscoverySearch" />
</Action>
</Schema>
</edmx:DataServices>
</edmx:Edmx>