Skip to content

chore: set correct parameter names #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MIchaelMainer merged 1 commit into from
Aug 14, 2025
Merged

chore: set correct parameter names #2975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,10 @@ jobs:
id: app-token
uses: actions/create-github-app-token@v2
with:
app_id: ${{ vars.RELEASE_PLEASE_TOKEN_PROVIDER_APP_ID }}
private_key: ${{ secrets.RELEASE_PLEASE_TOKEN_PROVIDER_PEM }}
installation_id: ${{ vars.RELEASE_PLEASE_TOKEN_PROVIDER_INSTALLATION_ID }}

app-id: ${{ vars.RELEASE_PLEASE_TOKEN_PROVIDER_APP_ID }}
Copy link

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter name should be app_id with underscores, not app-id with hyphens. According to the actions/create-github-app-token@v2 documentation, the correct parameter name is app_id.

Suggested change
app-id: ${{ vars.RELEASE_PLEASE_TOKEN_PROVIDER_APP_ID }}
app_id: ${{ vars.RELEASE_PLEASE_TOKEN_PROVIDER_APP_ID }}

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@MIchaelMainer MIchaelMainer Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot, you are hallucinating. Please review the documentation again.

https://github.com/actions/create-github-app-token

private-key: ${{ secrets.RELEASE_PLEASE_TOKEN_PROVIDER_PEM }}
Copy link

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter name should be private_key with underscores, not private-key with hyphens. According to the actions/create-github-app-token@v2 documentation, the correct parameter name is private_key.

Suggested change
private-key: ${{ secrets.RELEASE_PLEASE_TOKEN_PROVIDER_PEM }}
private_key: ${{ secrets.RELEASE_PLEASE_TOKEN_PROVIDER_PEM }}

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@MIchaelMainer MIchaelMainer Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot, you are hallucinating. Please review the documentation again.

https://github.com/actions/create-github-app-token


- name: Release Please
uses: googleapis/release-please-action@v4
with:
token: ${{ steps.app-token.outputs.token }}
token: ${{ steps.app-token.outputs.token }}
Loading