Skip to content

Update test baselines for EF Core 10 parameter naming convention#117

Merged
renemadsen merged 3 commits intomasterfrom
copilot/fix-p-0-sql-issue
Nov 17, 2025
Merged

Update test baselines for EF Core 10 parameter naming convention#117
renemadsen merged 3 commits intomasterfrom
copilot/fix-p-0-sql-issue

Conversation

Copy link

Copilot AI commented Nov 17, 2025

EF Core 10 simplified SQL parameter naming from @__p_0 to @p (PR dotnet/efcore#35200). Test baselines in ComplexTypeQueryMySqlTest.cs were still using the old format, causing assertion failures.

Changes

  • Updated 32 SQL baseline assertions in ComplexTypeQueryMySqlTest.cs to use @p instead of @__p_0
  • Affects LIMIT/OFFSET parameter references in complex type query tests

Example

-@__p_0='1'
+@p='1'

 SELECT DISTINCT `c0`.`Id`, ...
 FROM (
     SELECT `c`.`Id`, ...
     FROM `Customer` AS `c`
     ORDER BY `c`.`Id`
-    LIMIT 18446744073709551610 OFFSET @__p_0
+    LIMIT 18446744073709551610 OFFSET @p
 ) AS `c0`

This is an upstream breaking change affecting all EF Core providers. Additional test files may require similar updates as they fail.

Original prompt

This section details on the original issue you should resolve

<issue_title>Fix @_p_0= issue</issue_title>
<issue_description>It seems there is a change in the sql generated. Investigate if it's some change we made or it's expected in the base. Compare to sql server, sqlite implementaions for .net core 10

[xUnit.net 00:00:34.06]     Pomelo.EntityFrameworkCore.MySql.FunctionalTests.Query.ComplexTypeQueryMySqlTest.Load_complex_type_after_subquery_on_entity_type(async: False) [FAIL]
[xUnit.net 00:00:34.06]       Assert.Equal() Failure: Strings differ
[xUnit.net 00:00:34.06]                   ↓ (pos 1)
[xUnit.net 00:00:34.06]       Expected: "@__p_0='1'\n\nSELECT DISTINCT `c0`.`Id`, `c"···
[xUnit.net 00:00:34.06]       Actual:   "@p='1'\n\nSELECT DISTINCT `c0`.`Id`, `c0`.`"···
[xUnit.net 00:00:34.06]                   ↑ (pos 1)
[xUnit.net 00:00:34.06]       Stack Trace:
[xUnit.net 00:00:34.06]            at Microsoft.EntityFrameworkCore.TestUtilities.TestSqlLoggerFactory.AssertBaseline(String[] expected, Boolean assertOrder, Boolean forUpdate)
[xUnit.net 00:00:34.06]         /home/runner/work/Pomelo.EntityFrameworkCore.MySql/Pomelo.EntityFrameworkCore.MySql/test/EFCore.MySql.FunctionalTests/Query/ComplexTypeQueryMySqlTest.cs(1170,0): at Pomelo.EntityFrameworkCore.MySql.FunctionalTests.Query.ComplexTypeQueryMySqlTest.AssertSql(String[] expected)
[xUnit.net 00:00:34.06]         /home/runner/work/Pomelo.EntityFrameworkCore.MySql/Pomelo.EntityFrameworkCore.MySql/test/EFCore.MySql.FunctionalTests/Query/ComplexTypeQueryMySqlTest.cs(141,0): at Pomelo.EntityFrameworkCore.MySql.FunctionalTests.Query.ComplexTypeQueryMySqlTest.Load_complex_type_after_subquery_on_entity_type(Boolean async)
[xUnit.net 00:00:34.06]         --- End of stack trace from previous location ---
[xUnit.net 00:00:34.06]       Output:
[xUnit.net 00:00:34.06]         ---- New Baseline -------------------------------------------------------------------
[xUnit.net 00:00:34.06]                 AssertSql(
[xUnit.net 00:00:34.06]         """
[xUnit.net 00:00:34.06]         @p='1'
[xUnit.net 00:00:34.06]         
[xUnit.net 00:00:34.06]         SELECT DISTINCT `c0`.`Id`, `c0`.`Name`, `c0`.`BillingAddress_AddressLine1`, `c0`.`BillingAddress_AddressLine2`, `c0`.`BillingAddress_Tags`, `c0`.`BillingAddress_ZipCode`, `c0`.`BillingAddress_Country_Code`, `c0`.`BillingAddress_Country_FullName`, `c0`.`OptionalAddress_AddressLine1`, `c0`.`OptionalAddress_AddressLine2`, `c0`.`OptionalAddress_Tags`, `c0`.`OptionalAddress_ZipCode`, `c0`.`OptionalAddress_Country_Code`, `c0`.`OptionalAddress_Country_FullName`, `c0`.`ShippingAddress_AddressLine1`, `c0`.`ShippingAddress_AddressLine2`, `c0`.`ShippingAddress_Tags`, `c0`.`ShippingAddress_ZipCode`, `c0`.`ShippingAddress_Country_Code`, `c0`.`ShippingAddress_Country_FullName`
[xUnit.net 00:00:34.06]         FROM (
[xUnit.net 00:00:34.06]             SELECT `c`.`Id`, `c`.`Name`, `c`.`BillingAddress_AddressLine1`, `c`.`BillingAddress_AddressLine2`, `c`.`BillingAddress_Tags`, `c`.`BillingAddress_ZipCode`, `c`.`BillingAddress_Country_Code`, `c`.`BillingAddress_Country_FullName`, `c`.`OptionalAddress_AddressLine1`, `c`.`OptionalAddress_AddressLine2`, `c`.`OptionalAddress_Tags`, `c`.`OptionalAddress_ZipCode`, `c`.`OptionalAddress_Country_Code`, `c`.`OptionalAddress_Country_FullName`, `c`.`ShippingAddress_AddressLine1`, `c`.`ShippingAddress_AddressLine2`, `c`.`ShippingAddress_Tags`, `c`.`ShippingAddress_ZipCode`, `c`.`ShippingAddress_Country_Code`, `c`.`ShippingAddress_Country_FullName`
[xUnit.net 00:00:34.06]             FROM `Customer` AS `c`
[xUnit.net 00:00:34.06]             ORDER BY `c`.`Id`
[xUnit.net 00:00:34.06]             LIMIT 18446744073709551610 OFFSET @p
[xUnit.net 00:00:34.06]         ) AS `c0`
[xUnit.net 00:00:34.06]         """);
[xUnit.net 00:00:34.06]         
[xUnit.net 00:00:34.06]         

```</issue_description>

<agent_instructions>Remember this is .net core 10</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits November 17, 2025 11:57
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…Test

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with @_p_0= in generated SQL Update test baselines for EF Core 10 parameter naming convention Nov 17, 2025
Copilot AI requested a review from renemadsen November 17, 2025 12:03
@renemadsen renemadsen marked this pull request as ready for review November 17, 2025 12:29
@renemadsen renemadsen merged commit b5007ef into master Nov 17, 2025
0 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix @_p_0= issue

2 participants