Skip to content

Fix DELETE with self-referencing subquery tests for MySQL/MariaDB < 11.0 #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renemadsen merged 4 commits into from
Dec 16, 2025
Merged

Fix DELETE with self-referencing subquery tests for MySQL/MariaDB < 11.0 #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f69fef1
Initial plan
Copilot Dec 16, 2025
4d9b353
Fix DELETE with self-referencing subquery issue for MySQL/MariaDB < 11.0
Copilot Dec 16, 2025
43049cb
Fix Delete_with_cross_join test for MySQL/MariaDB < 11.0
Copilot Dec 16, 2025
b340298
Fix additional DELETE tests with self-referencing subqueries in North…
Copilot Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions test/EFCore.MySql.FunctionalTests/BulkUpdates/NonSharedModelBulkUpdatesMySqlTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using Microsoft.EntityFrameworkCore.TestUtilities;
using MySqlConnector;
using Pomelo.EntityFrameworkCore.MySql.FunctionalTests.TestUtilities;
using Pomelo.EntityFrameworkCore.MySql.Tests;
using Xunit;

namespace Pomelo.EntityFrameworkCore.MySql.FunctionalTests.BulkUpdates;
Expand Down Expand Up @@ -53,9 +54,11 @@ public override async Task Delete_aggregate_root_when_table_sharing_with_non_own

public override async Task Delete_predicate_based_on_optional_navigation(bool async)
{
await base.Delete_predicate_based_on_optional_navigation(async);
if (AppConfig.ServerVersion.Supports.DeleteWithSelfReferencingSubquery)
{
await base.Delete_predicate_based_on_optional_navigation(async);

AssertSql(
AssertSql(
"""
DELETE `p`
FROM `Posts` AS `p`
Expand All @@ -66,6 +69,14 @@ public override async Task Delete_predicate_based_on_optional_navigation(bool as
WHERE `b`.`Title` LIKE 'Arthur%'
)
""");
}
else
{
// Not supported by MySQL and older MariaDB versions:
// Error Code: 1093. You can't specify target table 'p' for update in FROM clause
await Assert.ThrowsAsync<MySqlException>(
() => base.Delete_predicate_based_on_optional_navigation(async));
}
}

public override async Task Update_non_owned_property_on_entity_with_owned(bool async)
Expand Down Expand Up @@ -130,9 +141,11 @@ public override async Task Update_non_main_table_in_entity_with_entity_splitting

public override async Task Delete_entity_with_auto_include(bool async)
{
await base.Delete_entity_with_auto_include(async);
if (AppConfig.ServerVersion.Supports.DeleteWithSelfReferencingSubquery)
{
await base.Delete_entity_with_auto_include(async);

AssertSql(
AssertSql(
"""
DELETE `c`
FROM `Context30572_Principal` AS `c`
Expand All @@ -142,6 +155,14 @@ public override async Task Delete_entity_with_auto_include(bool async)
LEFT JOIN `Context30572_Dependent` AS `c1` ON `c0`.`DependentId` = `c1`.`Id`
)
""");
}
else
{
// Not supported by MySQL and older MariaDB versions:
// Error Code: 1093. You can't specify target table 'c' for update in FROM clause
await Assert.ThrowsAsync<MySqlException>(
() => base.Delete_entity_with_auto_include(async));
}
}

public override async Task Update_with_alias_uniquification_in_setter_subquery(bool async)
Expand Down
Loading
Loading