Skip to content

Add missing test override for Subquery_over_primitive_collection_on_inheritance_derived_type#271

Merged
renemadsen merged 2 commits intov10.0.3from
copilot/fix-broken-test-implement-overrides
Feb 11, 2026
Merged

Add missing test override for Subquery_over_primitive_collection_on_inheritance_derived_type#271
renemadsen merged 2 commits intov10.0.3from
copilot/fix-broken-test-implement-overrides

Conversation

Copy link

Copilot AI commented Feb 11, 2026

EF Core 10.0.3 added Subquery_over_primitive_collection_on_inheritance_derived_type to NonSharedPrimitiveCollectionsQueryRelationalTestBase, breaking the Check_all_tests_overridden assertion.

Changes

  • Added override for Subquery_over_primitive_collection_on_inheritance_derived_type() in NonSharedPrimitiveCollectionsQueryMySqlTest
  • Follows existing pattern: calls base implementation, then asserts SQL with empty assertion (test skips when primitive collections support is disabled)
public override async Task Subquery_over_primitive_collection_on_inheritance_derived_type()
{
    await base.Subquery_over_primitive_collection_on_inheritance_derived_type();

    AssertSql();
}
Original prompt

This section details on the original issue you should resolve

<issue_title>Fix broken test and implement full missing overrides</issue_title>
<issue_description>After updating dependencies to 10.0.3, we have failing tests:

Failed Pomelo.EntityFrameworkCore.MySql.FunctionalTests.Query.NonSharedPrimitiveCollectionsQueryMySqlTest.Check_all_tests_overridden [< 1 ms]
Error Message:

-- Missing test overrides --

public override async Task Subquery_over_primitive_collection_on_inheritance_derived_type()
{
await base.Subquery_over_primitive_collection_on_inheritance_derived_type();

AssertSql(); // implement correct assert here

}

</issue_description>

<agent_instructions>Restore. Build. nsure database is runing before runing the specific test. Implement fix. run specific fixed test before committing anything, reiterate if not passing.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…nheritance_derived_type

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix broken test and implement missing overrides Add missing test override for Subquery_over_primitive_collection_on_inheritance_derived_type Feb 11, 2026
Copilot AI requested a review from renemadsen February 11, 2026 15:24
@renemadsen renemadsen marked this pull request as ready for review February 11, 2026 16:41
@renemadsen renemadsen merged commit 08803d4 into v10.0.3 Feb 11, 2026
169 of 174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants