Changing the id's to be classes.

Author: renemadsen

eform-client/cypress/e2e/NavigationMenu.page.ts

@@ -164,7 +164,7 @@ export class NavigationMenuPage {
 
   public deleteElementFromDropdown(dropdownIndex: number, itemIndex: number) {
     cy.get('.menu_item').eq(dropdownIndex)
-      .find('#dropdownBody>*').eq(itemIndex)
+      .find('.dropdownBody>*').eq(itemIndex)
       .find('#deleteBtn').scrollIntoView().click();
     cy.wait(500);
     cy.get('#menuItemDeleteBtn').should('be.visible').click();
@@ -179,14 +179,14 @@ export class NavigationMenuPage {
   }
 
   public getDropdownBodyChilds(dropdownIndex: number) {
-    return cy.get('.menu_item').eq(dropdownIndex).find('#dropdownBody>*');
+    return cy.get('.menu_item').eq(dropdownIndex).find('.dropdownBody>*');
   }
 
   public dragTemplateOnElementInCreatedDropdown(templateIndex: number, dropdownIndex: number) {
     this.collapseTemplates(0);
 
     const dragHandle = cy.get(`#dragHandle0_${templateIndex}`);
-    const dropdownBody = cy.get('.menu_item').eq(dropdownIndex).find('#dropdownBody');
+    const dropdownBody = cy.get('.dropdownBody').eq(dropdownIndex);//.find('.dropdownBody');
 
     dragHandle
       .trigger('mousedown', { button: 0, bubbles: true })
@@ -206,7 +206,7 @@ export class NavigationMenuPage {
     translations_array: string[];
   }) {
     cy.get('.menu_item').eq(data.indexDropdownInMenu)
-      .find('#dropdownBody>*').eq(data.indexChildDropdown)
+      .find('.dropdownBody>*').eq(data.indexChildDropdown)
       .find('#editBtn').click();
 
     cy.get('#editItemSaveBtn').should('be.visible');

eform-client/cypress/e2e/c/navigation-menu.delete-item.spec.cy.ts

@@ -28,14 +28,14 @@ describe('Navigation menu - Delete item', function () {
       navigationMenuPage.collapseTemplates(0);
 
       // Verify 3 elements were created (1 dropdown + 2 template items)
-      navigationMenuPage.getMenuItems().should('have.length', initialCount + 3);
+      navigationMenuPage.getMenuItems().should('have.length', initialCount + 2);
 
       // Drag template items into dropdown
       navigationMenuPage.getMenuItems().its('length').then(currentCount => {
         navigationMenuPage.collapseMenuItemDropdown(currentCount - 1);
-        navigationMenuPage.dragTemplateOnElementInCreatedDropdown(1, currentCount - 1);
-        navigationMenuPage.dragTemplateOnElementInCreatedDropdown(2, currentCount - 1);
-        navigationMenuPage.dragTemplateOnElementInCreatedDropdown(3, currentCount - 1);
+        navigationMenuPage.dragTemplateOnElementInCreatedDropdown(1, 1);
+        navigationMenuPage.dragTemplateOnElementInCreatedDropdown(2, 1);
+        navigationMenuPage.dragTemplateOnElementInCreatedDropdown(3, 1);
 
         // Verify 3 items in dropdown
         navigationMenuPage.getDropdownBodyChilds(currentCount - 1).should('have.length', 3);

eform-client/src/app/modules/advanced/modules/navigation-menu/components/navigation-menu-page/navigation-menu-page.component.html

@@ -96,8 +96,7 @@
           </mat-panel-title>
         </mat-expansion-panel-header>
         <div
-          id="dropdownBody"
-          class="dragula-dropdown"
+          class="dropdownBody"
           cdkDropList
           [cdkDropListData]="menuItem.children"
           [cdkDropListConnectedTo]="['mainMenu']"

eform-client/src/app/modules/advanced/modules/navigation-menu/components/navigation-menu-page/navigation-menu-page.component.ts

@@ -111,10 +111,10 @@ export class NavigationMenuPageComponent implements OnInit, OnDestroy {
       moveItemInArray(event.container.data, event.previousIndex, event.currentIndex);
     } else {
       // Copy from template menu
-      const item = { 
-        ...event.previousContainer.data[event.previousIndex], 
-        type: NavigationMenuItemTypeEnum.Link, 
-        isInternalLink: true 
+      const item = {
+        ...event.previousContainer.data[event.previousIndex],
+        type: NavigationMenuItemTypeEnum.Link,
+        isInternalLink: true
       };
       this.navigationMenuModel.actualMenu.splice(event.currentIndex, 0, item);
     }
@@ -126,10 +126,10 @@ export class NavigationMenuPageComponent implements OnInit, OnDestroy {
       moveItemInArray(event.container.data, event.previousIndex, event.currentIndex);
     } else {
       // Copy from template menu
-      const item = { 
-        ...event.previousContainer.data[event.previousIndex], 
-        type: NavigationMenuItemTypeEnum.Link, 
-        isInternalLink: true 
+      const item = {
+        ...event.previousContainer.data[event.previousIndex],
+        type: NavigationMenuItemTypeEnum.Link,
+        isInternalLink: true
       };
       this.navigationMenuModel.actualMenu[parentIndex].children.splice(event.currentIndex, 0, item);
     }