Remove external dependency on flake-utils
#447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for creating such a useful abstraction over VMs!
Would you be open to reducing the size of your dependency tree?
flake-utilsis only used for theeachSystemfunction. Inlining or replacing it cuts the project's lockfile in half (asflake-utilsitself depends on another flake).All of these commits remove the external dependency in different ways; let me know if you would like me to amend or remove any of them:
forAllSystems, including an MIT header.currentSystemif the flake is run with--impure. I'm guessing that most developers depending onflake-utilsare unaware of this behavior – in my opinion explicitly relying onnix-systemsfor this behavior is a better way to achieve this goal.While this PR aims to remove the external dependency on
flake-utilsin the simplest way possible, in the long term, I suggest rewriting the flake with aforAllSystemsfunction for better readability (you won't need to merge two big attrsets, instead keeping it all top-level).