Skip to content

Issue #13 + dev improvements#14

Merged
oscarotero merged 8 commits intomasterfrom
issue/13
Mar 15, 2025
Merged

Issue #13 + dev improvements#14
oscarotero merged 8 commits intomasterfrom
issue/13

Conversation

@filisko
Copy link
Member

@filisko filisko commented Mar 15, 2025

Hi,

Issue #13 fix and dev improvements.

Question: Is it a good idea to put dev stuff In changelogs? (I'm new 😄 )

@oscarotero
Copy link
Member

oscarotero commented Mar 15, 2025

Hi. Thanks for this!

Is it a good idea to put dev stuff In changelogs?

I don't usually do it because doesn't affect to the users of the library. The only exception is for testing (i.e. improved tests) because it makes the library more reliable.

In addition to this changes, can you also update the workflow file?
Just copy/paste the content of the most recent released package. For example: https://github.com/middlewares/negotiation/blob/master/.github/workflows/main.yaml

@filisko
Copy link
Member Author

filisko commented Mar 15, 2025

@oscarotero you're welcome! I was just going for the actions/checkout@v2 deprecation 😄 sure, I'll copy it

I don't usually do it because doesn't affect to the users of the library. The only exception is for testing (i.e. improved tests) because it makes the library more reliable.

OK, yes. It keeps it cleaner too and more straightforward. In this case the tests still the same.

@filisko
Copy link
Member Author

filisko commented Mar 15, 2025

Related PR for CI error:

This needs to go first.

oscarotero/php-cs-fixer-config#2

@oscarotero oscarotero merged commit 722e463 into master Mar 15, 2025
9 checks passed
@oscarotero oscarotero deleted the issue/13 branch March 15, 2025 17:38
@oscarotero
Copy link
Member

Thank you!

filisko pushed a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants