Conversation
storeman
reviewed
Apr 24, 2025
| }); | ||
|
|
||
| return !($handler instanceof PlainTextHandler && $handler->loggerOnly()); | ||
| if ($plainTextWithLoggerOnly && count($plainTextWithLoggerOnly) === count($handlers)) { |
There was a problem hiding this comment.
If I understand correctly, you try to find out if there is a PlainTextHandler present in the handlers. I don't understand what the ->isLoggerOnly() does.
That said, I think this method can be somewhat simpler. The count($handlers) === 0 block can be removed.
After the array filter you can just do return count($plainTextWithLoggerOnly) > 0;
Member
Author
There was a problem hiding this comment.
loggerOnly makes the PlainTextHandler work as a logger only. So it logs but it doesn't output anything.
So, why do you use 2 handlers if both have output and the last overwrites the previous one?
Member
Author
There was a problem hiding this comment.
@storeman just removed the === 0 condition - check it and I create the release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have a look to this @storeman. Specially the tests