Skip to content

WIP: Convert CV2 <-> CV1 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rahzael wants to merge 22 commits into
base: develop
Choose a base branch
from
+669 −0
Open

WIP: Convert CV2 <-> CV1 #85

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
be3eead
chore: Added nix flake for starting a development shell.
Rahzael Jan 17, 2026
f92f690
feat: Implemented conversion from CV2 note on to CV1.
Rahzael Jan 17, 2026
25f85f3
fix: Fixes issue with CV1 velocity calculation when converting from CV2.
Rahzael Jan 17, 2026
422fe59
test: Added test to ensure that CV2 -> CV1 velocity is always > 0 so …
Rahzael Jan 17, 2026
b3edac4
Revert "chore: Added nix flake for starting a development shell."
Rahzael Jan 18, 2026
5e7f877
fix: Remove CV1 NotOn alias in CV2 -> CV1 trait implementation.
Rahzael Jan 18, 2026
d3d1e84
docs: Add comment that 0 Vel CV2 will produce 1 Vel CV1.
Rahzael Jan 18, 2026
153a832
refactor: Makes CV2 Note On -> CV1 Note On generic over Buffer<Unit =…
Rahzael Jan 19, 2026
f437cf5
feat: Added direct CV2 -> CV1 Note On for resizable buffers.
Rahzael Jan 19, 2026
485c405
refactor: Moved Channeled and Grouped trait import to function body o…
Rahzael Jan 19, 2026
50fcc15
Feat: Added upscaling for all ranges but upper range and downscaling …
Rahzael Jan 20, 2026
f52c651
fix: Fixed center implementation to round up instead of down.
Rahzael Jan 21, 2026
0156ba2
feat: Implemented mincentermax upscaling for upper range.
Rahzael Jan 21, 2026
9217b38
refactor: Removed dbg! output in upscale() and unnesecary mut in CV2 …
Rahzael Jan 21, 2026
d7c12a6
style: Resolve clippy errors.
Rahzael Jan 21, 2026
5df1533
refactor: Moved From<CV2> note on to CV1 note on file.
Rahzael Jan 22, 2026
c9f8984
refactor: Move conversion module to its own file.
Rahzael Jan 26, 2026
9ff2e85
test: Added downscaling test for center values.
Rahzael Jan 29, 2026
dc5309b
test: Added min, max, and example downscaling tests.
Rahzael Jan 29, 2026
97e65e2
style: Removed unnesecary module nesting in conversion.rs.
Rahzael Jan 29, 2026
234feae
feat: Implemented zero extension upscaling.
Rahzael Jan 29, 2026
0793172
feat: Added Zero-Extension downscaling.
Rahzael Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
/target
/Cargo.lock
midi2_proc/target
midi2_proc/Cargo.lock
367 changes: 367 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading