fix: fix mnode scripts and update code owners#26
Conversation
|
|
|
|
|
Great job, no security vulnerabilities found in this Pull Request |
stevanlohja
changed the title
gilescope
left a comment
gilescope
left a comment
There was a problem hiding this comment.
mindight-node.sh should not run bash
|
@gilescope So, midnight-sh to run node instead? I was having an issue with midnight-node.sh when we initially had that to run the node, but I think* I can make it work. Will try and PR. |
midnight-node.sh
Outdated
|
|
||
| docker exec -t midnight /midnight-node "$@" | ||
| # Docker compose up midnight-node interactively in shell. | ||
| docker compose -f compose.yml up No newline at end of file |
There was a problem hiding this comment.
Before midnight-node.sh could be run with arguments. It's going to ignore all arguments with this definition.
There was a problem hiding this comment.
Using the previous command it wants the container running...
What if we simply delete midnight-node.sh and just have midnight-shell.sh to simply assist with the registration part, then they can docker compose up midnight node?
There was a problem hiding this comment.
Updated midnight-node script
3 participants
No description provided.