Skip to content

fix accept forks #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gilescope wants to merge 4 commits into from
Closed

fix accept forks #50

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbac19f
fix: accept-forks
gilescope Sep 4, 2025
3ca721f
debug: show generated sarif file
gilescope Sep 4, 2025
0f3813a
fix: go back to prior way that works.
gilescope Sep 4, 2025
fa00baf
Merge branch 'main' into giles-fix-accept-forks2
gilescope Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/checkmarx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,22 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Check access
if: ${{ github.event.pull_request.author_association != 'COLLABORATOR' && github.event.pull_request.author_association != 'OWNER' && github.event.pull_request.author_association != 'MEMBER' }}
# From https://michaelheap.com/access-secrets-from-forks/
# Also see https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/
- name: Get User Permission
id: checkAccess
uses: actions-cool/check-user-permission@7b90a27f92f3961b368376107661682c441f6103 #v2
with:
require: write
username: ${{ github.triggering_actor }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Check User Permission
if: steps.checkAccess.outputs.require-result == 'false'
run: |
echo "This job needs re-running by someone with collaboration permissions."
echo "${{ github.triggering_actor }} does not have permissions on this repo."
echo "Current permission level is ${{ steps.checkAccess.outputs.user-permission }}"
echo "Job originally triggered by ${{ github.actor }}"
exit 1

# This is dangerous without the first access check
Expand Down Expand Up @@ -112,7 +124,7 @@ jobs:
- uses: actions/upload-artifact@v4
with:
name: cx_result-sarif
path: cx_result.sarif
path: ./cx_result.sarif

# Upload results to github
- name: Upload SARIF file
Expand Down
Loading