157 : Make HTML Field theme-aware (light/dark support) #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the HTML Field iframe rendering so embedded HTML content properly follows the application’s light/dark theme. Previously, the iframe was isolated from parent styles and fell back to browser defaults.
Key Changes
--mie-color-*) from the parent editor/renderer root:rootso styles stay in syncMutationObserver)Behavior
p, headings, lists, tables, code, etc.) render with readable, theme-consistent stylesImplementation Notes
getComputedStyle()to read actual resolved theme valuesFiles Changed
HTML_Field.jsxTesting
<style>-based user HTML is not overriddenHere’s a clean PR-ready section you can drop straight into the PR description under Testing or How to Test.
It’s concise, explicit, and reviewer-friendly.
How to Test (Local Package Validation)
This change was validated using a local packed build of the package and installed into an external project to verify real-world behavior.
Steps:
From the
questionnaire-builderrepo:# which builds the packages and pack it locally for you insdie of ./localpackages/... npm run pack:localLocate the generated tarball(s) in:
In the consuming project (e.g.
bluehive-aior another external app), install the local package:Start the consuming application and verify:
Notes: