Added delete feature and text viewer functionality#131
Open
dayal18 wants to merge 1 commit intomifi:masterfrom
Open
Added delete feature and text viewer functionality#131dayal18 wants to merge 1 commit intomifi:masterfrom
dayal18 wants to merge 1 commit intomifi:masterfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two major features to improve file management and usability.
🚀 New Features
Backend: Added a new DELETE /api/delete endpoint in packages/lib that securely removes files using fs.unlink. It includes path validation to prevent directory traversal attacks.
Frontend: Added a generic onDelete prop to the FileRow component in web/src/routes/dir/$dirId.tsx.
UI: A "Delete" (Trash) icon now appears next to files in the browser list. Clicking it triggers a confirmation prompt before deletion.
Detection: Added mightBeText utility in web/src/util.ts to detect common text/code extensions (.txt, .md, .json, .js, etc.).
UI: Text files are now clickable in the file browser.
Viewer: The file viewer modal (web/src/routes/dir/$dirId/file.tsx) now supports fetching and displaying text content in a scrollable, dark-themed code block.
UX: Added user-select: text and proper zIndex handling to ensure text content is selectable and copyable, fixing issues with overlapping UI controls.