Fixed platform selection in loadTsConfig.ts

[SimonSimCity]

os.platform is a function (https://nodejs.org/api/os.html#osplatform), returning a string.

Fixes #20

[t3chguy]

@mighdoll in case this slipped through the cracks, users of electron-builder (a downstream of yours) would really appreciate this landing and being released :) keep up the good work

[awdr74100]

@mighdoll releasing it will give the electron-builder config good type support! Let's do it!

[mighdoll]

hmm... tests don't pass with this on the windows machine I just fired up. do they work for you? pnpm test

[mighdoll]

the integration test 'loading a config file' does pass on windows with this patch, so very possibly the test failures are a separate issue.

@awdr74100 @SimonSimCity have you been using the patched version successfully? If so, we can fix the tests separately.

[CatStudioApp]

the integration test 'loading a config file' does pass on windows with this patch, so very possibly the test failures are a separate issue.

@awdr74100 @SimonSimCity have you been using the patched version successfully? If so, we can fix the tests separately.

We've been using the patched version for a while of this PR.

# Script to modify index.js due to <https://github.com/mighdoll/config-file-ts/issues/19>

# Get current path of this script
$currentPath = $PSScriptRoot

# Define the relative path to the index.js file
$relativePath = "../../../../../web/node_modules/config-file-ts/dist/index.js"

# Combine the paths to get the full path to index.js
$indexPath = Join-Path $currentPath $relativePath

# Check if the file exists
if (Test-Path $indexPath) {
    # Read the contents of the file
    $fileContent = Get-Content $indexPath -Raw

    # Replace the specified string
    $fileContent = $fileContent -replace 'os.platform.name', 'os.platform()'

    # Write the changes back to the file
    Set-Content $indexPath -Value $fileContent

    Write-Host "File updated successfully."
} else {
    Write-Error "File not found: $indexPath"
}

[mighdoll]

ok, thanks good to know that it's working for you. I'm adding another test too to verify that the cache works.

[mighdoll]

btw, do you know about 'patch-package'? It's handy for tweaking upstream packages like this. Someone showed it to me a while ago and I've found it useful, so I thought I'd pass the tip along in case you hadn't seen it.

[t3chguy]

btw, do you know about 'patch-package'? It's handy for tweaking upstream packages like this. Someone showed it to me a while ago and I've found it useful, so I thought I'd pass the tip along in case you hadn't seen it.

It isn't intended for use in published packages ds300/patch-package#198

[mighdoll]

ah, good point

[mighdoll]

published 0.2.8-rc1.

Let me know if that works!

[t3chguy]

@mighdoll can confirm it works - used resolutions to eagerly update config-file-ts in element-hq/element-desktop#1591 - Thanks!

[slogivewd]

Please merge this