MTA-4775: Effort differs between applications depending on whether th… #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey can be built or not Signed-off-by: A.Arnold <[email protected]>
Signed-off-by: A.Arnold <[email protected]>
anarnold97
commented
Mar 14, 2025
anarnold97
commented
Mar 14, 2025
Signed-off-by: A.Arnold <[email protected]>
Signed-off-by: A.Arnold <[email protected]>
anarnold97
commented
Mar 18, 2025
Signed-off-by: A.Arnold <[email protected]>
anarnold97
force-pushed
the
MTA-4775-effort-application-built-or-not
branch
from
2bd04c8 to
2c0e713
Compare
anarnold97
commented
Mar 18, 2025
anarnold97
commented
Mar 18, 2025
anarnold97
commented
Mar 18, 2025
|
|
kpunwatk
reviewed
Mar 19, 2025
docs/topics/issues-with-report.adoc
Outdated
| [id="issues-with-report_{context}"] | ||
| = Issues with reports | ||
|
|
||
| Analysis precision is lower when the project cannot be built for whatever reasons. This lowering of precision can be caused by several factors; |
There was a problem hiding this comment.
Hi @anarnold97 Replace the semicolon with a colon since it introduces a list,
This lowering of precision can be caused by several factors:
|
|
||
| Analysis precision is lower when the project cannot be built for whatever reasons. This lowering of precision can be caused by several factors; | ||
|
|
||
| * The lack of a proper build file, such as, a `pom.xml` or `build.gradle` file. For example, running {ProductFullName} on a project with an inaccessible parent `pom.xml` file may not result in a full analysis. |
There was a problem hiding this comment.
I'm not sure, I guess there is Unnecessary Comma "such as,"
There was a problem hiding this comment.
@kpunwatk - it would be acceptable with a comma or without. However, as it is going into a two-item list, i think it reads better as it gives emphasis to the pom.xl and gradle.file.
As this is the last remaining issue, are you ok for me to move it Release Pending, please?
Thanks
There was a problem hiding this comment.
Completely ok for me, Thanks!
PR looks good to me!
anarnold97
commented
Mar 19, 2025
kpunwatk
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
PREVIEW
CLI - 5. Issues with reports
Web console - 7.6.1. Issues with reports