Merge post-GA 7.2.2 - MTA-4828: Removing discrete headers #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarnold97
force-pushed
the
MTA-remove-discrete-headers
branch
from
e572f63 to
3371398
Compare
Signed-off-by: A.Arnold <[email protected]>
anarnold97
force-pushed
the
MTA-remove-discrete-headers
branch
from
24965c1 to
f1fc098
Compare
shdeshpa07
reviewed
Apr 2, 2025
Pkylas007
reviewed
Apr 2, 2025
Pkylas007
reviewed
Apr 2, 2025
|
LGTM, I have only a few minor suggestions. |
shdeshpa07
reviewed
Apr 2, 2025
| @@ -96,7 +96,7 @@ The `<not>` element has no unique attributes or child elements. | |||
| [id="iterable-filter-syntax_{context}"] | |||
| ==== <iterable-filter> syntax | |||
There was a problem hiding this comment.
Suggested change
| ==== <iterable-filter> syntax |
There was a problem hiding this comment.
Not applicable in the scope of this PR
| @@ -96,7 +96,7 @@ The `<not>` element has no unique attributes or child elements. | |||
| [id="iterable-filter-syntax_{context}"] | |||
There was a problem hiding this comment.
Suggested change
| [id="iterable-filter-syntax_{context}"] |
There was a problem hiding this comment.
Is this required? There is a similar id below - iterable-filter-syntax-summary?
|
Added a comment about duplicate id. Otherwise, LGTM w.r.t removing [discrete] headers. |
Signed-off-by: A.Arnold <[email protected]>
anarnold97
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
PR to remove
[discrete]headers from the MTA doc-set