NAR CLI support #44
NAR CLI support #44
Conversation
|
Looks great. Do we know if the logs command has any issues similar to NAB? |
|
The flow of NAR work with NABs, the flag IncludeNamespaceScopedResources is only supposed to be in NABs, and includednamespaces and other namespace spec fields in NARs are not admin enforceable and restricted so specifying namespace should not be allowed I believe. I changed the code to remove the fields not allowed in NAR such as the one mentioned. |
cmd/non-admin/backup/describe.go
Outdated
| } | ||
|
|
||
| // NonAdminDescribeBackupDetailed provides a Velero-style detailed output format | ||
| func NonAdminDescribeBackupDetailed(cmd *cobra.Command, kbClient kbclient.Client, nab *nacv1alpha1.NonAdminBackup, userNamespace string, ctx context.Context) error { |
There was a problem hiding this comment.
Hmm here is thought, Instead of implementing NonAdminDescribeBackupDetailed from scratch, consider leveraging Velero's existing describe logic and filtering the output for non-admin users. Like get the describe output then stream it to a filtering function and then present the refined output for non-admin users. WDYGT ? @Joeavaikath @NicholasYancey (We will have significantly less code to maintain 😉)
Let me know your thoughts on this.
|
Please resolve conflicts |
|
Continued by #57 |
No description provided.