Fix keyboard toggle flicker on iOS#465
Closed
alvarolb wants to merge 2 commits intomigueldeicaza:mainfrom
Closed
Conversation
alvarolb
force-pushed
the
main
branch
5 times, most recently
from
6abe995 to
3f38c5f
Compare
Owner
|
You mixed up two commits. |
Replace resignFirstResponder/becomeFirstResponder cycle with reloadInputViews() wrapped in performWithoutAnimation when switching between the standard keyboard and the custom KeyboardView. This avoids the keyboard dismiss/show animation that causes multiple layout passes and terminal flickering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing to resubmit with a clean single commit (removing unrelated cherry-picked changes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the
resignFirstResponder/becomeFirstRespondercycle intoggleInputKeyboardwithreloadInputViews()wrapped inUIView.performWithoutAnimation.The current implementation dismisses and re-shows the keyboard on every toggle, causing multiple layout passes and visible terminal flickering. Using
reloadInputViews()swaps the input view in-place without the keyboard dismiss/show animation.Changes
iOSAccessoryView.swift: Replaced resign/become cycle withreloadInputViews()inperformWithoutAnimationBefore / After
Before: Each keyboard toggle triggers resign → keyboard dismiss animation → inputView swap → become → keyboard show animation → multiple
layoutSubviews→ terminal flickerAfter: Input view swaps instantly, no animation, no flicker