feat: cross-OS config file and docs cleanup#22
Merged
miguelgila merged 4 commits intomainfrom Feb 26, 2026
Merged
Conversation
These plans have been fully implemented and are no longer needed: - PLAN-quickstart-playground.md (playground script shipped) - VERSIONING_PLAN.md (replaced by RELEASING.md) - INTEGRATION_TEST_PLAN.md (all 14 tests implemented) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the Debian-specific /etc/default/containerd env-file approach with a Reaper-owned config file that works on any Linux distribution. Both binaries now load /etc/reaper/reaper.conf at startup (KEY=VALUE format). Environment variables override file values for backward compatibility. The Ansible playbook writes config to the new location and cleans up the legacy systemd drop-in if present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add Rust integration tests (tests/integration_config.rs) verifying config file loading, env var override precedence, and missing file handling. Add K8s integration test verifying /etc/reaper/reaper.conf exists on nodes with correct content (29/29 pass). Update README, deploy/kubernetes/README, and example 08 to reference the config file as the standard configuration method. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLAN-quickstart-playground.md,VERSIONING_PLAN.md,INTEGRATION_TEST_PLAN.md(all fully implemented)/etc/reaper/reaper.confat startup, replacing the Debian-specific/etc/default/containerdenv-file approach. Works on any Linux distro (RHEL, SUSE, Alpine, Arch, etc.). Env vars still override file values for backward compatibility./etc/reaper/reaper.confinstead of/etc/default/containerd; removes legacy systemd drop-in if present.Test plan
cargo test --test integration_config— 3/3 pass (config loading, env override, missing file)cargo clippy --all-targets— clean./scripts/run-integration-tests.sh— 29/29 pass (includes new config file on node test)🤖 Generated with Claude Code