Skip to content

fix: serialize config unit tests to prevent CI race#23

Merged
miguelgila merged 1 commit intomainfrom
fix/config-test-race
Feb 27, 2026
Merged

fix: serialize config unit tests to prevent CI race#23
miguelgila merged 1 commit intomainfrom
fix/config-test-race

Conversation

@miguelgila
Copy link
Owner

Summary

  • Fix test parallelism race in config::tests that caused CI coverage failures
  • The config tests mutate the shared REAPER_CONFIG env var; without serialization, parallel test threads race on set_var/remove_var, causing intermittent NotPresent panics
  • Add #[serial] attribute (from serial_test crate, already a dev-dependency) to all 4 config tests

Test plan

  • cargo test config::tests — 8/8 pass (4 per binary)
  • cargo clippy --all-targets — clean

🤖 Generated with Claude Code

The config tests mutate shared REAPER_CONFIG env var. Without
serialization, parallel test threads race on set_var/remove_var,
causing intermittent NotPresent failures in CI coverage runs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.94%. Comparing base (eaa34f4) to head (246b5a6).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   86.20%   85.94%   -0.27%     
==========================================
  Files           4        5       +1     
  Lines         174      185      +11     
==========================================
+ Hits          150      159       +9     
- Misses         24       26       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@miguelgila miguelgila merged commit c7ef98f into main Feb 27, 2026
9 of 10 checks passed
@miguelgila miguelgila deleted the fix/config-test-race branch February 28, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant