fix: cosign Helm chart signing — add GHCR auth and sign by digest#37
Merged
miguelgila merged 1 commit intomainfrom Mar 16, 2026
Merged
fix: cosign Helm chart signing — add GHCR auth and sign by digest#37miguelgila merged 1 commit intomainfrom
miguelgila merged 1 commit intomainfrom
Conversation
Cosign in the helm-chart job failed because it uses Docker/OCI credentials (~/.docker/config.json) which were never set up — only Helm's credential store was configured. Add docker/login-action@v3 to provide GHCR push credentials to cosign. Also switch from signing by tag (deprecated) to signing by digest, matching the pattern used in the container-images job. Fixes #36 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 84.66% 85.04% +0.38%
==========================================
Files 6 6
Lines 300 301 +1
==========================================
+ Hits 254 256 +2
+ Misses 46 45 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker/login-action@v3tohelm-chartjob so cosign has GHCR push credentials (previously only Helm's credential store was configured)helm pushoutput and sign by digest instead of tag (tag signing is deprecated by cosign)Fixes #36
Test plan
workflow_dispatch) and verify thehelm-chartjob's cosign step succeedscosign verify🤖 Generated with Claude Code