fix: implement dynamic PTY resize (ResizePty)#57
Merged
miguelgila merged 1 commit intomainfrom Mar 21, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
- Coverage 85.01% 84.78% -0.23%
==========================================
Files 6 6
Lines 307 309 +2
==========================================
+ Hits 261 262 +1
- Misses 46 47 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The shim's ResizePty was a no-op, causing interactive terminals to be stuck at 80x24. Implement file-based IPC between shim and runtime daemon: - Shim writes "width height" to /run/reaper/<id>/resize (or exec variant) - Runtime daemon polls the resize file every 100ms via a watcher thread - On change, daemon applies TIOCSWINSZ ioctl to the PTY master fd Supports both do_start() and exec_with_pty() PTY sessions. Closes #56 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
f075ca6 to
9e1ac78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
width heightto/run/reaper/<id>/resize(orexec-<exec_id>-resizefor exec sessions)TIOCSWINSZioctl to the PTY master fddo_start()andexec_with_pty()PTY sessions#[cfg(target_os = "linux")]Closes #56
Test plan
cargo clippy --workspace --all-targets -- -D warningspasses (macOS)cargo clippy --target x86_64-unknown-linux-gnu --all-targets -- -D warningspasses (Linux cross-compile)cargo test --workspacepasses (152 tests)kubectl exec -it <reaper-pod> -- bashand resize terminal window, then runps auxfto confirm full-width output🤖 Generated with Claude Code