Fix tricky issue in handling of websocket.receive messages #405
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi — I were debugging a customer issue for work at Modal (modal.com) and discovered that the python engine.io implementation behaves slightly differently from the ASGI spec, which suggests that:
> Exactly one of bytes or text must be non-None. One or both keys may be present, however.
The Python engineio client fails connection on Modal currently because it gets a dict:
```
{'type': 'websocket.send', 'bytes': None, 'text': '40{"sid":"gK4jeac7mjv1pc6kAAAB"}'}
```
But it checks for presence with `'bytes' in event`, rather than `event.get('bytes') is not None`.
This is a quick fix for the issue — let me know if this makes sense or if you'd want me to help add a test as well!
ekzhang
added a commit
to modal-labs/modal-client
that referenced
this pull request
May 14, 2025
The python-engineio library has a small bug in its ASGI server implementation, which I reported here miguelgrinberg/python-engineio#405 Anyway we can also make the Modal client send messages in a way that doesn't trigger this bug.
ekzhang
added a commit
to modal-labs/modal-client
that referenced
this pull request
May 14, 2025
The python-engineio library has a small bug in its ASGI server implementation, which I reported here miguelgrinberg/python-engineio#405 Anyway we can also make the Modal client send messages in a way that doesn't trigger this bug.
Owner
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi — I was debugging a customer issue for work at Modal (modal.com) and discovered that the python engine.io implementation behaves slightly differently from the ASGI spec, which suggests that:
The Python engineio client fails connection on Modal currently because it gets a dict:
But it checks for presence with
'bytes' in event, rather thanevent.get('bytes') is not None.This is a quick fix for the issue — let me know if this makes sense or if you'd want me to help add a test as well!