Skip to content

fix AsyncClient::wait unexpected return after success reconnect #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2024
Merged

fix AsyncClient::wait unexpected return after success reconnect #1407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4224a6
fix AsyncClient::wait unexpected return after success reconnect
arkuzo Nov 19, 2024
29256e5
Making added check easier to understand in source code
arkuzo Nov 19, 2024
1663d4a
fix Client::wait unexpected return after success reconnect
arkuzo Nov 19, 2024
9fad09f
fixes
miguelgrinberg Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/socketio/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ async def wait(self):
await self.eio.wait()
await self.sleep(1) # give the reconnect task time to start up
if not self._reconnect_task:
if self.eio.state == 'connected': # pragma: no cover
# connected while sleeping above
continue
break
await self._reconnect_task
if self.eio.state != 'connected':
Expand Down
7 changes: 6 additions & 1 deletion src/socketio/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,12 @@ def wait(self):
self.eio.wait()
self.sleep(1) # give the reconnect task time to start up
if not self._reconnect_task:
break
if self.eio.state == 'connected': # pragma: no cover
# connected while sleeping above
continue
else:
# the reconnect task gave up
break
self._reconnect_task.join()
if self.eio.state != 'connected':
break
Expand Down
Loading