Add the reason argument for async_admin when socket disconnect #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, I forgot that the Admin UI can show the reason. Thank you so much, I'll review your change and merge over the next few days. |
src/socketio/async_server.py
Outdated
| await self._trigger_event('disconnect', namespace, sid, | ||
| reason or self.reason.CLIENT_DISCONNECT) | ||
| await self.manager.disconnect(sid, namespace, ignore_queue=True) | ||
| await self.manager.disconnect(sid, namespace, reason=reason or self.reason.CLIENT_DISCONNECT, ignore_queue=True) |
|
@Yixiu1121 Thanks for contributing the fix. Unfortunately the solution needed to be more complicated than this, so I ended up implementing this fix separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am using python-socketio with an Admin UI and noticed that the disconnect reason is not being displayed. I have made some modifications to address this issue. Could you please review my pull request?
Thank you for your time and consideration!