Restore binary message support in message queue setups (Fixes #1508) #1509
+194
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 2615 2640 +25
Branches 448 452 +4
=========================================
+ Hits 2615 2640 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miguelgrinberg
force-pushed
the
binary-packets-on-message-queue
branch
from
dc1b853 to
c78c035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores the ability to send binary messages in setups that use a message queue.
A regression was introduced in #1502, where the encoding used on packets transmitted between hosts in the message queue was switched from pickle to JSON to eliminate the risks associated with the pickle module. Due to the JSON encoding, any messages that included binary data would not send. This change restores the support for binary data, using the same mechanism used to transmit these messages over JSON between server and client.