Skip to content

Validate admin namespace and event #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Validate admin namespace and event #1511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 32 additions & 6 deletions src/socketio/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,22 +172,48 @@ def config(sid):

self.sio.start_background_task(config, sid)

def _valid_namespace(self, namespace):
# Check that a namespace exists and is not the admin namespace.
return (
isinstance(namespace, str)
and namespace
and namespace in self.sio.manager.get_namespaces()
and namespace != self.admin_namespace
)

def _valid_room(self, room):
return isinstance(room, str) and room

def admin_emit(self, _, namespace, room_filter, event, *data):
# Validate
if not self._valid_namespace(namespace):
return

if not isinstance(event, str) or not event \
or event.startswith('_') or event in ['connect', 'disconnect', 'connect_error']:
return

self.sio.emit(event, data, to=room_filter, namespace=namespace)

def admin_enter_room(self, _, namespace, room, room_filter=None):
for sid, _ in self.sio.manager.get_participants(
namespace, room_filter):
if not self._valid_namespace(namespace) or not self._valid_room(room):
return

for sid, _ in self.sio.manager.get_participants(namespace, room_filter):
self.sio.enter_room(sid, room, namespace=namespace)

def admin_leave_room(self, _, namespace, room, room_filter=None):
for sid, _ in self.sio.manager.get_participants(
namespace, room_filter):
if not self._valid_namespace(namespace) or not self._valid_room(room):
return

for sid, _ in self.sio.manager.get_participants(namespace, room_filter):
self.sio.leave_room(sid, room, namespace=namespace)

def admin_disconnect(self, _, namespace, close, room_filter=None):
for sid, _ in self.sio.manager.get_participants(
namespace, room_filter):
if not self._valid_namespace(namespace):
return

for sid, _ in self.sio.manager.get_participants(namespace, room_filter):
self.sio.disconnect(sid, namespace=namespace)

def shutdown(self):
Expand Down