Prevent thread starvation in TransactionContext.kt #2951
+40
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of places seem to be eating threads (kotlin task parallelism as a language feature is a bit of a mess to be honest), but the
TransactionContext.ktseems to be the worst offender.This change resolves that in two ways:
If the lock is hit, the thread can yield, meaning that threads can't pile up waiting for the database. This primarily helps responsiveness.
It is one of the places I identified that has this problem. In general, a lot of IO seems to block the threads instead of either yielding or using the IO pool, causing responsiveness issues. Every one of those changes might have unintended consequences though, so I will only open these PRs in small portions.