Fix: Add legacy storage permission check for saving covers#3106
Open
leodyversemilla07 wants to merge 1 commit intomihonapp:mainfrom
Open
Fix: Add legacy storage permission check for saving covers#3106leodyversemilla07 wants to merge 1 commit intomihonapp:mainfrom
leodyversemilla07 wants to merge 1 commit intomihonapp:mainfrom
Conversation
leodyversemilla07
force-pushed
the
fix/save-cover-storage-permission
branch
6 times, most recently
from
a6c19ef to
6d33e78
Compare
6 tasks
Request WRITE_EXTERNAL_STORAGE permission on Android < Q when saving manga covers or reader images. Added rememberLegacyStoragePermissionState composable to track permission state and show dialog when needed.
leodyversemilla07
force-pushed
the
fix/save-cover-storage-permission
branch
from
6d33e78 to
7e7c5bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3097 - Saving manga covers and reader images would fail silently without proper storage permission on Android versions below Android 10 (Q).
Changes
Testing