Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes above ensure cache locality and reduce mem fragmentation risks.
TL;DR: Cache locality means accessing memory that's physically close together.
Memory fragmentation might happen when we have free memory, but it's scattered in small chunks that can't be used efficiently, which is the case when using std::set.
Oversimplified illustration of mem fragmentation
Also, std::vector allocates 4 bytes per element , 4 to 5 times less than std::set which allocates ~24-32 bytes per node (pointers for left child, right child, parent, plus color bit for red-black tree)