fix: enable inline parsing of content with marked v13+#366
Open
jayree wants to merge 1 commit intomikaelbr:masterfrom
Open
fix: enable inline parsing of content with marked v13+#366jayree wants to merge 1 commit intomikaelbr:masterfrom
jayree wants to merge 1 commit intomikaelbr:masterfrom
Conversation
bolinfest
added a commit
to openai/codex
that referenced
this pull request
May 13, 2025
This PR uses [`pnpm patch`](https://www.petermekhaeil.com/til/pnpm-patch/) to pull in the following proposed fixes for `marked-terminal`: * mikaelbr/marked-terminal#366 * mikaelbr/marked-terminal#367 This adds a substantial test to `codex-cli/tests/markdown.test.tsx` to verify the new behavior. Note that one of the tests shows two citations being split across a line even though the rendered version would fit comfortably on one line. Changing this likely requires a subtle fix to `marked-terminal` to account for "rendered length" when determining line breaks.
agentydragon
pushed a commit
to agentydragon/codex
that referenced
this pull request
Jun 26, 2025
This PR uses [`pnpm patch`](https://www.petermekhaeil.com/til/pnpm-patch/) to pull in the following proposed fixes for `marked-terminal`: * mikaelbr/marked-terminal#366 * mikaelbr/marked-terminal#367 This adds a substantial test to `codex-cli/tests/markdown.test.tsx` to verify the new behavior. Note that one of the tests shows two citations being split across a line even though the rendered version would fit comfortably on one line. Changing this likely requires a subtle fix to `marked-terminal` to account for "rendered length" when determining line breaks.
UziTech
approved these changes
Jun 27, 2025
buihongduc132
pushed a commit
to buihongduc132/codex
that referenced
this pull request
Sep 9, 2025
This PR uses [`pnpm patch`](https://www.petermekhaeil.com/til/pnpm-patch/) to pull in the following proposed fixes for `marked-terminal`: * mikaelbr/marked-terminal#366 * mikaelbr/marked-terminal#367 This adds a substantial test to `codex-cli/tests/markdown.test.tsx` to verify the new behavior. Note that one of the tests shows two citations being split across a line even though the rendered version would fit comfortably on one line. Changing this likely requires a subtle fix to `marked-terminal` to account for "rendered length" when determining line breaks.
Contributor
|
@mikaelbr can we get this merged? |
hyperz111
added a commit
to hyperz111/marked-terminal
that referenced
this pull request
Dec 2, 2025
boatri
added a commit
to boatri/linear-agent
that referenced
this pull request
Feb 15, 2026
marked-terminal breaks bold/code rendering inside list items with marked v13+. Pin to v11 until the upstream fix lands. Tracking: mikaelbr/marked-terminal#366 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #304
@mikaelbr