Reproduce and fix 175 #178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eConfig" Refer the mainClass value set to buildType of the nativeImage task. This fix expects that the project has only one nativeImage task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sharing your great Gradle plugin, it helped me a lot to challenge
native-image!By this PR I want to suggest a fix for #175. Refer to this workflow run to confirm that the test case surely reproduces the reported issue.
Note that this fix expects that the Gradle project always have only one
NativeImageTasktype task, to refer a property (buildType) ofNativeImageTaskfromGenerateNativeImageConfigTask.