forked from apache/cordova-plugin-media
-
Notifications
You must be signed in to change notification settings - Fork 0
updating from master #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mike-nelson
wants to merge
150
commits into
mike-nelson:master
Choose a base branch
from
apache:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n submitted…" This closes #118
This closes #116
In order to play the audio file with the html <audio> tag in iOS: 1. change OutputFormat from RAW_AMR to AAC_ADTS 2. change OutputFormat from AMR_NB to AAC
Add engine tag for checking the version of "cordova-android".
Update for format of Android audio, from .amr to .aac. This closes #124
…tatus handling compatible with Android/Windows implement a "messageChannel" command and if the messageChannel command is called the plugin hands back results to the plugin container via "sendPluginResult" instead of "evalJs" even for oldschool usage it cleans the code Closes #134.
When I try to get the position of an audio that had an error while loading, the crash appose exponentially because it can not cast the time = none Co-authored-by: LKS <[email protected]>
* test(spec.timeout): improve safe complete for before and after each spec * test(spec.timeout): add done to success callback * test(spec.timeout): set DEFAULT_TIMEOUT_INTERVAL to ACTUAL_PLAYBACK_TEST_TIMEOUT
#354) Co-authored-by: yunseok <[email protected]>
* CB-11641 android: add 'message' field to media error It was not possible before to get error message.This updated Android implementation to return error code with message similar to iOS. * style: apply lint corrections * refactor(android): private API sendStatusChange Co-authored-by: Nikita Matrosov <[email protected]>
* chore: bump version 7.0.0-dev * chore: add cordovaDependencies for 7.0.0
* dep(dev)!: bump @cordova/[email protected] * chore: apply automatic lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
What does this PR do?
What testing has been done on this change?
Checklist