Prevent error on mixin when remove innexisting listener ember 3.12#317
Open
romgere wants to merge 1 commit intomike-north:masterfrom
romgere:master
Open
Prevent error on mixin when remove innexisting listener ember 3.12#317romgere wants to merge 1 commit intomike-north:masterfrom romgere:master
romgere wants to merge 1 commit intomike-north:masterfrom
romgere:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On ember 3.12, on acceptance test we encountered the error below :
You attempted to remove a function listener which did not exist on the instance, which means you may have attempted to remove it before it was added.The error is throwed by the
resize-awaremixin inside thewillDestroyElementmethod when trying to remove thedidResizeand/ordebouncedDidResizelistener.From my understanding, the
willDestroyElementis called without a call todidInsertElement.This PR aim to fix this.
Related to #316