Open
Conversation
- Add GitHub Actions CI workflow with PHP 8.1-8.5 matrix - Include Laravel 10/11/12 cross-testing with sensible exclusions - Update README requirements to reflect PHP 8.1+ including 8.5 - Existing composer.json constraint ^8.1 already covers PHP 8.5
mikebronner
commented
Mar 1, 2026
Owner
Author
mikebronner
left a comment
There was a problem hiding this comment.
Review Checklist
The following items need to be addressed before this is ready:
- phpunit.xml.dist is incompatible with PHPUnit 11: The config uses deprecated PHPUnit 9 attributes (
backupStaticAttributes,convertErrorsToExceptions,convertNoticesToExceptions,convertWarningsToExceptions) and the old<coverage>format. These cause errors/warnings under PHPUnit 10+/11. Since the CI workflow runsvendor/bin/phpunitand the dev deps pull PHPUnit 11, this config needs to be modernized. - No non-browser tests exist: The only test is a Dusk browser test requiring Chromedriver. The CI workflow uses
--exclude-group browser, which means zero tests actually run in CI. AC requires "all tests pass with zero failures on PHP 8.5" — passing vacuously with zero tests doesn't satisfy the spirit of that criterion. At minimum, add a basic unit test that verifies the package boots and the service provider registers correctly. -
tests/Featuredirectory referenced in phpunit.xml.dist doesn't exist: This causes a hard error when running phpunit without flags. Either remove the Feature testsuite from the config or create the directory. - composer.json already had
"php": "^8.1": The diff shows no changes to composer.json — which means the php constraint already covered 8.5 via^8.1. The AC item about updating composer.json is technically satisfied, but worth confirming this was intentional rather than an oversight (perhaps a more explicit upper bound was expected). - README still says "Laravel 8.0+": The README update only changed the PHP line. The Laravel version range should also be reviewed — the package requires
^10.0|^11.0|^12.0but the README says "Laravel 8.0+".
- Update phpunit.xml.dist to PHPUnit 11 schema (remove deprecated PHPUnit 9 attributes, use <source> instead of <coverage>) - Remove non-existent Feature testsuite from phpunit.xml.dist - Add ServiceProviderTest with 4 unit tests verifying provider registration, Socialite driver, config merging, and Blade directive - Fix README Laravel version from 8.0+ to 10.0+ to match composer.json
mikebronner
commented
Mar 1, 2026
Owner
Author
mikebronner
left a comment
There was a problem hiding this comment.
Review Complete ✅
All acceptance criteria verified · Code quality looks good · Unit tests passing (4/4) · No issues found.
CI workflow added with PHP 8.1–8.5 × Laravel 10–12 matrix, appropriate exclusions. phpunit.xml.dist modernized for PHPUnit 11 (removed deprecated attributes, switched coverage→source). Cache driver changed from redis to array for tests — good call. New ServiceProviderTest covers registration, socialite driver, config merge, and blade directive. README updated.
Browser test failure is a chromedriver environment issue, not a code problem.
Ready for your final review and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add PHP 8.5 compatibility to the package by updating the composer.json version constraint, adding a CI workflow with a PHP 8.5 test job, resolving any deprecation warnings, and updating the README version support documentation.
Acceptance Criteria
composer.jsonversion constraint updated to include PHP 8.5 (e.g.^8.2|^8.5or>=8.2)composer updatecompletes without conflicts under PHP 8.5Fixes #57