Open
Conversation
- Update illuminate/support to include ^13.0 - Update orchestra/testbench to include ^11.0 - Update orchestra/testbench-browser-kit to include ^11.0 - Update orchestra/testbench-dusk to include ^11.0 - Bump minimum PHP to ^8.2 (Laravel 13 requires PHP 8.3+, but keeping ^8.2 for older Laravel versions)
Include PHP 8.2-8.4 and Laravel 10-13 in the CI matrix. Laravel 13 requires PHP 8.3+, so PHP 8.2 is excluded from that job.
- Update minimum PHP to 8.2+ and Laravel to 10.0+ - Add version support table showing Laravel 10-13 compatibility
mikebronner
commented
Mar 1, 2026
Owner
Author
mikebronner
left a comment
There was a problem hiding this comment.
Review Checklist
The following items need to be addressed before this is ready:
- phpunit.xml.dist references non-existent
tests/Featuredirectory: Runningvendor/bin/phpunitfails immediately with "Test directory not found." The CI workflow runsvendor/bin/phpunitwithout any flags, so this will also fail in CI. Either remove the Feature testsuite from phpunit.xml.dist or create the directory. - phpunit.xml.dist uses deprecated PHPUnit 9 attributes:
backupStaticAttributes,convertErrorsToExceptions,convertNoticesToExceptions,convertWarningsToExceptions, and the old<coverage>format are all removed/changed in PHPUnit 10+/11. This config needs to be modernized. - No non-browser tests exist: The only test requires Chromedriver/Dusk. AC requires tests passing — zero runnable tests doesn't meet that bar. Add at least a basic integration test (service provider boots, routes registered, etc.).
- PHP constraint bumped from
^8.1to^8.2without explanation: The PR title is about Laravel 13 support, but the PHP floor was raised from 8.1 to 8.2. This is fine if intentional (Laravel 13 requires 8.3+), but note that the CI matrix also runs PHP 8.2 + Laravel 13 which should be excluded since Laravel 13 requires PHP 8.3+. The exclude block only removesphp: 8.2 / laravel: 13.*— good, that's correct. But confirm the PHP floor bump is intended. - CI uses wildcard version syntax (
10.*) vs caret (^10.0): Inconsistent with composer.json which uses^10.0. While functionally similar for thecomposer requirecommand, it's better to be consistent. Minor nit — not a blocker.
- Remove deprecated PHPUnit 9 attributes (backupStaticAttributes, convertErrorsToExceptions, etc.) - Update to PHPUnit 11 schema with <source> instead of <coverage> - Remove non-existent Feature testsuite directory reference - Add unit tests for ServiceProvider (boots, config merged, Socialite driver registered, Blade directive registered) - Use caret version syntax in CI matrix for consistency with composer.json - Run only Unit testsuite in CI (Browser tests require Dusk/Chromedriver) - Add .phpunit.cache to .gitignore
mikebronner
commented
Mar 1, 2026
Owner
Author
mikebronner
left a comment
There was a problem hiding this comment.
Review Complete ✅
All acceptance criteria verified · Code quality looks good · Unit tests passing (4/4) · No issues found.
composer.json updated with ^13.0 for illuminate/support, testbench, testbench-browser-kit, and testbench-dusk. CI matrix properly covers PHP 8.2–8.4 × Laravel 10–13 with correct exclusion (PHP 8.2 + Laravel 13). phpunit.xml.dist modernized. New ServiceProviderTest with thorough config key assertions. README version table is clear.
PHP minimum bumped from ^8.1 to ^8.2 — correct for the supported Laravel range.
Ready for your final review and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Laravel 13 compatibility to the package by updating composer.json version constraints, CI matrix, and documentation.
Acceptance Criteria
composer.jsonversion constraint updated to include Laravel 13.x (e.g.^10.0|^11.0|^12.0|^13.0)composer updatecompletes without conflicts under Laravel 13Fixes #56