Skip to content

configure locationProvider to clean out the url hash#63

Open
omnikrll wants to merge 1 commit intomasterfrom
remove-url-hash
Open

configure locationProvider to clean out the url hash#63
omnikrll wants to merge 1 commit intomasterfrom
remove-url-hash

Conversation

@omnikrll
Copy link
Collaborator

That hash has been lowkey bothering me for a bit so i figured I'd clean it out.

@mikekaminsky
Copy link
Owner

mikekaminsky commented Jun 12, 2016

Locally, this link seems to be broken on this branch?
http://localhost:3000/admin

No` route matches [GET] "/admin"

Any ideas?

@omnikrll
Copy link
Collaborator Author

Oh weird! I'll take a look.

@se3000
Copy link
Collaborator

se3000 commented Jun 13, 2016

I think it has to be /#/admin
On Sun, Jun 12, 2016 at 6:13 PM Karl Hohn notifications@github.com wrote:

Oh weird! I'll take a look.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#63 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAjBg6EktADHHXYpfkz4KiiNaAkfsiSOks5qLISjgaJpZM4IzN1C
.

@mikekaminsky
Copy link
Owner

I thought the point of this PR was to remove the hash in the URL? LMK if I'm just totally missing something here :0

@omnikrll
Copy link
Collaborator Author

Yeah the intent is to get rid of the hash, and it works for navigating
around the listener-facing stuff, but to get to the admin side you still
have to type the hash for some reason.

On Monday, June 13, 2016, Michael notifications@github.com wrote:

I thought the point of this PR was to remove the hash in the URL? LMK if
I'm just totally missing something here :0


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#63 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ADzmdzrSj-sPSlArC3xz0xZ8W_nTp4ovks5qLXsQgaJpZM4IzN1C
.

@se3000
Copy link
Collaborator

se3000 commented Jun 13, 2016

Sorry, didn't realize that was the point of the PR. I'll shut up until I
can actually pay attention.

On Mon, Jun 13, 2016 at 11:50 AM Karl Hohn notifications@github.com wrote:

Yeah the intent is to get rid of the hash, and it works for navigating
around the listener-facing stuff, but to get to the admin side you still
have to type the hash for some reason.

On Monday, June 13, 2016, Michael notifications@github.com wrote:

I thought the point of this PR was to remove the hash in the URL? LMK if
I'm just totally missing something here :0


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#63 (comment),
or mute the thread
<
https://github.com/notifications/unsubscribe/ADzmdzrSj-sPSlArC3xz0xZ8W_nTp4ovks5qLXsQgaJpZM4IzN1C

.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#63 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAjBg0pgE5OMy6lCfuofjwUcp2qrji3Gks5qLXw7gaJpZM4IzN1C
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants