Skip to content

update paths#2037

Merged
mikel-brostrom merged 2 commits intomasterfrom
fix-benchmark
Jun 21, 2025
Merged

update paths#2037
mikel-brostrom merged 2 commits intomasterfrom
fix-benchmark

Conversation

@mikel-brostrom
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 21, 2025 09:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates file paths and command invocations in the benchmark workflow to reflect a new directory structure and tool call. Key changes include:

  • Replacing the old "tracking/val_utils" paths with "boxmot/engine/val_utils" in git clones, cache restores, and file operations.
  • Merging OS-specific sed commands into a unified command to update pyproject.toml.
  • Changing the evaluation command from a Python script invocation to "boxmot eval" to align with updated tooling.
Comments suppressed due to low confidence (3)

.github/workflows/benchmark.yml:85

  • Confirm that switching from a Python script call to 'boxmot eval' aligns with the updated tool's command interface and that the command is correctly available in the environment.
          if boxmot eval --classes 0 --yolo-model yolox_x_ablation.pt --reid-model lmbn_n_duke.pt --tracking-method ${{ matrix.tracker }} --verbose --source boxmot/engine/val_utils/data/MOT17-50/train; then

.github/workflows/benchmark.yml:45

  • Verify that the unified sed command works consistently across all intended operating environments, as the previous OS-specific branches have been removed.
          sed -i'' -e 's/index = "torch-gpu"/index = "torch-cpu"/g' pyproject.toml

.github/workflows/benchmark.yml:50

  • Ensure that the parent directories for 'boxmot/engine/val_utils' exist or are created before cloning, as git clone might fail if the parent directory is missing.
          git clone https://github.com/JonathonLuiten/TrackEval.git boxmot/engine/val_utils

@mikel-brostrom mikel-brostrom merged commit e67c20f into master Jun 21, 2025
19 checks passed
@mikel-brostrom mikel-brostrom deleted the fix-benchmark branch July 2, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants