Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates file paths and command invocations in the benchmark workflow to reflect a new directory structure and tool call. Key changes include:
- Replacing the old "tracking/val_utils" paths with "boxmot/engine/val_utils" in git clones, cache restores, and file operations.
- Merging OS-specific sed commands into a unified command to update pyproject.toml.
- Changing the evaluation command from a Python script invocation to "boxmot eval" to align with updated tooling.
Comments suppressed due to low confidence (3)
.github/workflows/benchmark.yml:85
- Confirm that switching from a Python script call to 'boxmot eval' aligns with the updated tool's command interface and that the command is correctly available in the environment.
if boxmot eval --classes 0 --yolo-model yolox_x_ablation.pt --reid-model lmbn_n_duke.pt --tracking-method ${{ matrix.tracker }} --verbose --source boxmot/engine/val_utils/data/MOT17-50/train; then
.github/workflows/benchmark.yml:45
- Verify that the unified sed command works consistently across all intended operating environments, as the previous OS-specific branches have been removed.
sed -i'' -e 's/index = "torch-gpu"/index = "torch-cpu"/g' pyproject.toml
.github/workflows/benchmark.yml:50
- Ensure that the parent directories for 'boxmot/engine/val_utils' exist or are created before cloning, as git clone might fail if the parent directory is missing.
git clone https://github.com/JonathonLuiten/TrackEval.git boxmot/engine/val_utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.