Removed setNoCFSRatio

[shubhamsrkdev]

Problem

Post Switching to a fixed CFS threshold #15295 in Lucene, setNoCFSRatio is removed.

Solution

Replaced setNoCFSRatio with setShouldUseCompoundFile

Testing

Ran this on same baseline and candidate

python src/python/localrun.py -source wikimedium10k

                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
            BrowseDateSSDVFacets     1660.38     (17.5%)     1476.24     (21.9%)  -11.1% ( -42% -   34%) 0.176
                           range     3624.40      (5.6%)     3409.74     (13.1%)   -5.9% ( -23% -   13%) 0.163
           HighTermDayOfYearSort     1651.21      (7.0%)     1592.22      (6.9%)   -3.6% ( -16% -   11%) 0.106
       BrowseDayOfYearTaxoFacets     2179.56      (6.9%)     2114.58      (8.7%)   -3.0% ( -17% -   13%) 0.229
                         Prefix3     1301.57     (10.6%)     1263.39      (7.8%)   -2.9% ( -19% -   17%) 0.319
                        Wildcard      789.33     (10.9%)      774.40     (12.2%)   -1.9% ( -22% -   23%) 0.605
     BrowseRandomLabelTaxoFacets     1129.99     (10.2%)     1108.98      (9.8%)   -1.9% ( -19% -   20%) 0.555
                        PKLookup       79.18     (22.7%)       78.00     (24.5%)   -1.5% ( -39% -   59%) 0.842
                        HighTerm     1870.40      (5.3%)     1847.43      (7.3%)   -1.2% ( -13% -   12%) 0.543
     BrowseRandomLabelSSDVFacets      759.86      (9.9%)      751.69     (12.5%)   -1.1% ( -21% -   23%) 0.764
                         LowTerm     3915.55      (6.8%)     3888.79      (5.0%)   -0.7% ( -11% -   11%) 0.716
           BrowseMonthSSDVFacets     3234.29     (11.4%)     3221.73     (12.7%)   -0.4% ( -21% -   26%) 0.919
                          Fuzzy2      180.63      (7.1%)      180.12      (3.9%)   -0.3% ( -10% -   11%) 0.876
                     AndHighHigh      964.52      (6.5%)      962.22      (7.6%)   -0.2% ( -13% -   14%) 0.915
               HighTermMonthSort     1160.95      (5.9%)     1159.18      (8.2%)   -0.2% ( -13% -   14%) 0.946
                          IntNRQ     1510.02      (8.3%)     1508.06      (9.1%)   -0.1% ( -16% -   18%) 0.962
                         Respell      340.86      (5.8%)      340.61      (6.7%)   -0.1% ( -11% -   13%) 0.970
            BrowseDateTaxoFacets     2381.14      (7.6%)     2382.07      (6.6%)    0.0% ( -13% -   15%) 0.986
                       OrHighLow     1317.59      (8.5%)     1322.31     (10.5%)    0.4% ( -17% -   21%) 0.906
                      AndHighLow     2257.04      (6.7%)     2266.48      (4.1%)    0.4% (  -9% -   12%) 0.813
                      OrHighHigh      862.02      (6.9%)      867.01      (7.6%)    0.6% ( -13% -   16%) 0.801
                         MedTerm     2513.03      (5.9%)     2547.16      (6.4%)    1.4% ( -10% -   14%) 0.486
                 MedSloppyPhrase     1024.54      (6.7%)     1040.39      (7.0%)    1.5% ( -11% -   16%) 0.474
                     LowSpanNear     1050.13      (6.3%)     1066.43     (10.3%)    1.6% ( -14% -   19%) 0.565
           BrowseMonthTaxoFacets     2180.66      (7.6%)     2216.13      (6.6%)    1.6% ( -11% -   17%) 0.470
       BrowseDayOfYearSSDVFacets     3151.91      (8.5%)     3206.60     (13.7%)    1.7% ( -18% -   26%) 0.631
                      AndHighMed     1248.74      (5.5%)     1271.38      (7.2%)    1.8% ( -10% -   15%) 0.372
                       LowPhrase     1018.70      (6.0%)     1047.64      (8.6%)    2.8% ( -11% -   18%) 0.226
                      HighPhrase      470.95      (6.5%)      485.94     (13.5%)    3.2% ( -15% -   24%) 0.342
             MedIntervalsOrdered      450.40      (7.8%)      466.15     (11.9%)    3.5% ( -15% -   25%) 0.271
                HighSloppyPhrase      625.69      (7.2%)      647.98     (10.4%)    3.6% ( -13% -   22%) 0.209
                          Fuzzy1      637.17      (9.5%)      661.19      (8.3%)    3.8% ( -12% -   23%) 0.182
            HighIntervalsOrdered      431.61      (7.6%)      448.17     (12.7%)    3.8% ( -15% -   26%) 0.247
                       OrHighMed      803.20      (8.7%)      837.83      (6.9%)    4.3% ( -10% -   21%) 0.083
                     MedSpanNear      588.90      (5.9%)      615.31     (12.7%)    4.5% ( -13% -   24%) 0.151
             LowIntervalsOrdered      494.71      (6.9%)      518.46     (15.6%)    4.8% ( -16% -   29%) 0.209
                       MedPhrase      414.62      (6.5%)      434.56     (14.1%)    4.8% ( -14% -   27%) 0.167
                 LowSloppyPhrase      396.21      (6.4%)      417.88     (13.6%)    5.5% ( -13% -   27%) 0.103
                    HighSpanNear      286.09      (7.5%)      303.75     (15.0%)    6.2% ( -15% -   31%) 0.100

[stefanvodita]

We no longer need this, right?

[shubhamsrkdev]

Ah right, we don't, removing.

[mikemccand]

Thank you @shubhamsrkdev @stefanvodita -- nightly benchy is indeed blocked -- I'll merge now!

[mikemccand]

Looks like python linter is unhappy ... I'll fix after merging.