Skip to content

Enable Compose Hot Reload for Desktop sample#407

Merged
mikepenz merged 1 commit intodevelopfrom
feature/compose_hot_relaod
May 25, 2025
Merged

Enable Compose Hot Reload for Desktop sample#407
mikepenz merged 1 commit intodevelopfrom
feature/compose_hot_relaod

Conversation

@mikepenz
Copy link
Owner

Description

  • add compose hot-reload capability

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build configuration change

@mikepenz mikepenz requested a review from Copilot May 25, 2025 12:27
@mikepenz mikepenz added the other label May 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces Compose hot-reload support for the desktop sample and updates build tooling.

  • Adds the Foojay resolver plugin to settings.gradle.kts
  • Bumps the version-catalog plugin from 0.3.7 to 0.3.8
  • Enables hot reload in the desktop sample’s gradle.properties

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
settings.gradle.kts Adds org.gradle.toolchains.foojay-resolver plugin and updates version-catalog
sample/desktop/gradle.properties Enables Compose hot reload via a new property
Comments suppressed due to low confidence (1)

sample/desktop/gradle.properties:2

  • [nitpick] Consider using a hyphenated key (com.mikepenz.hot-reload.enabled) to align with the dash-separated naming convention used by other plugin properties.
com.mikepenz.hotreload.enabled=true

@@ -1 +1,2 @@
com.mikepenz.binary-compatibility-validator.enabled=false No newline at end of file
com.mikepenz.binary-compatibility-validator.enabled=false
com.mikepenz.hotreload.enabled=true
Copy link

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Add a comment above this property explaining that it enables Compose hot-reload for the desktop sample, so future maintainers understand its purpose.

Copilot uses AI. Check for mistakes.
@mikepenz mikepenz merged commit 0fb86e4 into develop May 25, 2025
3 checks passed
@mikepenz mikepenz deleted the feature/compose_hot_relaod branch May 25, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant