Use coroutine to offload code highlighting to background thread#419
Merged
mikepenz merged 8 commits intomikepenz:developfrom Jul 4, 2025
Merged
Use coroutine to offload code highlighting to background thread#419mikepenz merged 8 commits intomikepenz:developfrom
mikepenz merged 8 commits intomikepenz:developfrom
Conversation
keta1
changed the title
mikepenz
reviewed
Jun 30, 2025
...code/src/commonMain/kotlin/com/mikepenz/markdown/compose/elements/MarkdownHighlightedCode.kt
Outdated
Show resolved
Hide resolved
Owner
|
can you please rebase? |
Contributor
Author
|
Rebased and force-pushed |
Owner
|
Thank you very much for your contribution @keta1 |
…ighlights builder This change It defaults to using the `SyntaxThemes.atom` theme and respects the system dark mode setting.
The `highlights` parameter in `MarkdownHighlightedCodeFence`, `MarkdownIndentedCodeBlock`, and `MarkdownHighlightedCode` has been renamed to `highlightsBuilder` for clarity. This change ensures consistency in naming and better reflects the parameter's purpose.
This commit introduces the use of coroutines to perform code highlighting in the background. This improves performance by preventing the UI thread from being blocked during the highlighting process. The `produceHighlightsState` composable function now launches a coroutine to calculate the highlights and updates the `AnnotatedString` state accordingly. This ensures that the UI remains responsive while the highlighting is in progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
highlightstohighlightsBuilderType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: